Support optional Mixpanel init config options #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you amenable to tackling the feature requested in ##229 too? |
This change should allow customizing |
|
What's the status of this? |
|
@vladucu this could use a rebase if you have the time. Once you do so I'm happy to merge. |
vladucu
force-pushed
the
enhance-mixpanel-config
branch
from
f2426ea
to
b3cf94d
Compare
vladucu
force-pushed
the
enhance-mixpanel-config
branch
from
b3cf94d
to
73b7fe6
Compare
|
@jherdman rebased. Thanks! |
jherdman
approved these changes
Jan 6, 2021
|
I believe this resolves #229 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for other optional config options for Mixpanel's
initcall.See https://developer.mixpanel.com/docs/javascript-full-api-reference#mixpanelinit for more